Allow to change isVideoMirrored option for front camera #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonandersen Could you please review and provide feedback if needed? |
|
@Awalz @jonandersen Any chance this PR gets merged, please? It's quite simple and I think it will benefit others. |
|
In what scenario would you not flip the front camera? (no the project owner, just curious) |
|
We are not flipping the front camera (but the preview layer!), so the exported video looks as if it was recorded with the back camera. For example, if you're holding a sign with letters, it will be readable in the exported video. |
|
Closing. Repo seems abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retaking #120 from master