Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better type hints and backfill missing descriptions #433

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

justlevine
Copy link
Member

What

Adds better type hints to our PHP Interfaces and Abstract classes, and as a result backfills several missing descriptions unearthed by the new hints.

Why

While I'm not ready to migrate this over to the Plugin Boilerplate's abstracts, I can at least backport nonbreaking enhancements.
 

How

Testing Instructions

Additional Info

Checklist:

  • This PR is tested to the best of my abilities.
  • This PR follows the WordPress Coding Standards.
  • This PR has proper inline documentation.
  • This PR has unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

@justlevine justlevine merged commit 8d8d94d into AxeWP:develop Jun 15, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant