Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with WooGraphQL product/variation types #105

Merged
merged 15 commits into from
Aug 11, 2024

Conversation

justlevine
Copy link
Member

@justlevine justlevine commented Aug 10, 2024

What

This PR fixes a compatibility issue with WPGraphQL for WooCommerce, where the seo GraphQL type was not getting narrowed correctly, leading conflicts between the type and interface.

Why

Fixes #99

How

  • A new Extensions namespace and requesite classes have been added to the lifecycle.
  • Internally, we loop through WP_GraphQL_WooCommerce::get_enabled_{product|product_variation}_types() to register/assign the requisite GraphQL type for the seo field.
  • A new INCLUDE_EXTENSIONS environment variable is used for installing woo/woographql.

Testing Instructions

Additional Info

Unit tests cannot be included until the ProductVariation.metaData interface conflict is fixed.

Checklist:

  • My code is tested to the best of my abilities.
  • My code follows the WordPress Coding Standards.
  • My code has proper inline documentation.
  • I have added unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

@justlevine justlevine changed the title fix: woographql interfaces fix: compatibility with WooGraphQL product/variation types Aug 10, 2024
@justlevine justlevine marked this pull request as ready for review August 10, 2024 19:09
@justlevine justlevine merged commit 52d053e into AxeWP:develop Aug 11, 2024
14 of 16 checks passed
@justlevine justlevine deleted the fix/wooseo-types branch August 11, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface Error in WPGraphQL IDE
1 participant