Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for secondary groups #56

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Added support for secondary groups #56

merged 5 commits into from
Nov 30, 2023

Conversation

madelen-at-work
Copy link
Contributor

@madelen-at-work madelen-at-work commented Nov 28, 2023 •
edited
Loading

NB! If a container needs sub-group access it has to use the group-add flag.

Describe your changes

Adding mapping for secondary groups to /etc/subgid. This makes it possible to add secondary groups to containers and have them mapped to real groups on the device.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

Added support for secondary groups
cd0f36e 
NB! If a container needs sub-group access it has to use the group-add flag.
@madelen-at-work madelen-at-work requested a review from a team as a code owner November 28, 2023 15:31
jojju
jojju reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jojju jojju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
killenheladagen
killenheladagen approved these changes Nov 30, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@madelen-at-work madelen-at-work merged commit ae22f48 into rootless-preview Nov 30, 2023
11 checks passed
@madelen-at-work madelen-at-work deleted the adding-groups branch November 30, 2023 14:32
deepikas20 pushed a commit that referenced this pull request Feb 21, 2024
@madelen-at-work @deepikas20
Added support for secondary groups (#56)
28e91ec 
* Added support for secondary groups

---------

Co-authored-by: madelen-axis <madelen-axis@users.noreply.github.com>
deepikas20 pushed a commit that referenced this pull request Mar 21, 2024
@madelen-at-work @deepikas20
Added support for secondary groups (#56)
6869981 
* Added support for secondary groups

---------

Co-authored-by: madelen-axis <madelen-axis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojju jojju jojju left review comments

@killenheladagen killenheladagen killenheladagen approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madelen-at-work @killenheladagen @jojju