Skip to content

Remove symlinks of docker-compose cli plugins and docker socket #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2024
Merged

Remove symlinks of docker-compose cli plugins and docker socket #59

merged 2 commits into from
Mar 6, 2024

Conversation

deepikas20
Copy link
Contributor

@deepikas20 deepikas20 commented Feb 15, 2024 •
edited
Loading

Describe your changes

Remove symlinks of docker-compose cli plugins and docker socket and add them in acapctl.

Issue ticket number and link

Jira ACAPSDK-1577
https://jira.se.axis.com/browse/ACAPSDK-1577

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@deepikas20 deepikas20 requested a review from a team as a code owner February 15, 2024 10:21
madelen-at-work
madelen-at-work requested changes Feb 15, 2024
View reviewed changes
@deepikas20
Remove the docker directory creation
4a7db09 
Change-Id: I8bdc12f185344ee36c0734bb1741ae0f29475b32
madelen-at-work
madelen-at-work approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@madelen-at-work madelen-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait to merge this until the FW changes are merged

@deepikas20 deepikas20 merged commit 38ca494 into rootless_shadow Mar 6, 2024
@deepikas20 deepikas20 deleted the rootless_remove_symlinks branch March 6, 2024 08:00
deepikas20 added a commit that referenced this pull request Mar 21, 2024
@deepikas20
Remove symlinks of docker-compose cli plugins and docker socket (#59)
663d1f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madelen-at-work madelen-at-work madelen-at-work approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepikas20 @madelen-at-work