Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new parameter to have an option to choose TCP socket creation #62

Closed
wants to merge 7 commits into from

Conversation

deepikas20
Copy link
Contributor

@deepikas20 deepikas20 commented Mar 18, 2024

Describe your changes

Changing 'Use TLS' parameter 's default option from yes to no in the manifest.json.
Adding a new parameter 'TCP Socket' to choose TCP socket creation.

Issue ticket number and link

https://jira.se.axis.com/browse/ACAPSDK-1545

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@deepikas20 deepikas20 requested a review from a team as a code owner March 18, 2024 15:41
Copy link
Contributor

@madelen-at-work madelen-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TLS certs only apply when TCP socket is used - If the user selects to not use TCP socket the TLS selection can be treated as always false. IPC socket does not use TLS at all.
Please change the implementation accordingly and also update the README so that this is clear to the developer/user

@deepikas20
Copy link
Contributor Author

I have tested the following possibilities:
TCP-yes
TLS-yes
IPC- yes
API listens on both TCP ::2376 and IPC /var/run/docker.sock

TCP-yes
TLS-yes
IPC- no
API listens on TCP ::2376

TCP-yes
TLS-no
IPC- yes
API listens on both TCP ::2375 and IPC /var/run/docker.sock

TCP-no
TLS-no
IPC- yes
API listens on IPC /var/run/docker.sock

TCP-no
TLS-yes
IPC- yes
Warning: "Set UseTLS as 'no' when TCP socket is set as 'no'."

TCP-yes
TLS-no
IPC- no
API listens on TCP ::2375

TCP-no
TLS-no
IPC- no
API listens on IPC /var/run/docker.sock since IPC socket is default.

@deepikas20 deepikas20 requested a review from a team March 19, 2024 14:12
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@deepikas20
Copy link
Contributor Author

deepikas20 commented Mar 20, 2024

Changes:

TCP-no
TLS-yes
IPC-yes
API listens on IPC /var/run/docker.sock

TCP-no
IPC- no
Dockerd doesn't start.
Warning: Dockerd fails to start. Either IPC socket or TCP socket should be selected

@madelen-at-work
Copy link
Contributor

Change merged to main via cherry-pick from docker-acap repo

@madelen-at-work madelen-at-work deleted the add-tcp-socket branch April 4, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants