-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new parameter to have an option to choose TCP socket creation #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TLS certs only apply when TCP socket is used - If the user selects to not use TCP socket the TLS selection can be treated as always false. IPC socket does not use TLS at all.
Please change the implementation accordingly and also update the README so that this is clear to the developer/user
I have tested the following possibilities: TCP-yes TCP-yes TCP-no TCP-no TCP-yes TCP-no |
Changes: TCP-no TCP-no |
Change merged to main via cherry-pick from docker-acap repo |
Describe your changes
Changing 'Use TLS' parameter 's default option from yes to no in the manifest.json.
Adding a new parameter 'TCP Socket' to choose TCP socket creation.
Issue ticket number and link
https://jira.se.axis.com/browse/ACAPSDK-1545
Checklist before requesting a review