Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused flags from old linking approach #264

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Remove unused flags from old linking approach #264

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
844e0bb
Remove unused flags from old linking approach
mithydolphin Nov 28, 2024
e917e09
Patch 2
mithydolphin Nov 30, 2024
1f40b06
patch 3
mithydolphin Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions tests/check/check_signed_video_auth.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,6 +1053,67 @@ START_TEST(add_one_sei_nalu_after_signing)
}
END_TEST

/* Test description
* Verify that we get a valid authentication if first two SEIs delayed and GOPs that belegs to those
* SEIs are removed.
*/
START_TEST(remove_two_gop_in_start_of_stream)
{
// Create a list of NAL Units given the input string.
test_stream_t *list = create_signed_nalus("IPIPIPPPIPPPPIPPIP", settings[_i]);
test_stream_check_types(list, "IPISPISPPPISPPPPISPPISP");

// Delay the first SEI by removing it from position 4 and appending it at position 5.
test_stream_item_t *sei = test_stream_item_remove(list, 4);
test_stream_item_check_type(sei, 'S');
test_stream_check_types(list, "IPIPISPPPISPPPPISPPISP");
test_stream_append_item(list, sei, 5);
test_stream_check_types(list, "IPIPISSPPPISPPPPISPPISP");
// Delay the second SEI by removing it from position 7 and appending it at position 8.
sei = test_stream_item_remove(list, 7);
test_stream_item_check_type(sei, 'S');
test_stream_check_types(list, "IPIPISPPPISPPPPISPPISP");
test_stream_append_item(list, sei, 8);
test_stream_check_types(list, "IPIPISPPSPISPPPPISPPISP");

// Remove the first 2 GOPs.
test_stream_t *removed_list = test_stream_pop(list, 4);
test_stream_check_types(removed_list, "IPIP");
test_stream_free(removed_list);
test_stream_check_types(list, "ISPPSPISPPPPISPPISP");

signed_video_accumulated_validation_t final_validation = {
SV_AUTH_RESULT_NOT_OK, false, 19, 16, 3, SV_PUBKEY_VALIDATION_NOT_FEASIBLE, true, 0, 0};
// ISPPSPISPPPPISPPISP
//
// IS PU -> (signature)
// ISPPS NUNN. -> (invalid)
// PIS MMMNP. -> (invalid)
// ISPPPPIS ......P. -> (valid)
// ISPPIS ....P. -> (valid)
struct validation_stats expected = {.valid_gops = 2,
.invalid_gops = 2,
bjornvolcker marked this conversation as resolved.
Show resolved Hide resolved
.pending_nalus = 4,
.missed_nalus = 2,
.has_signature = 1,
.final_validation = &final_validation};
// ISPPSPISPPPPISPPISP
// IS PMU -> (signature)
// ISPPS NMUNN. -> (invalid)
// PIS MMM.P. -> (valid with missing info)
// ISPPPPIS ......P. -> (valid)
// ISPPIS ....P. -> (valid)
if (settings[_i].auth_level == SV_AUTHENTICITY_LEVEL_FRAME) {
expected.valid_gops_with_missing_info = 1;
expected.invalid_gops = 1;
expected.final_validation->authenticity = SV_AUTH_RESULT_NOT_OK;
}
validate_nalu_list(NULL, list, expected, true);

test_stream_free(list);
}
END_TEST

/* Test description
* Verify that we do get a valid authentication if the signing on the camera was reset. From a
* signed video perspective this action is correct as long as recorded NAL Units are not transmitted
Expand Down Expand Up @@ -2152,6 +2213,7 @@ signed_video_suite(void)
tcase_add_loop_test(tc, lost_g_and_gop_with_late_sei_arrival, s, e);
tcase_add_loop_test(tc, lost_all_nalus_between_two_seis, s, e);
tcase_add_loop_test(tc, add_one_sei_nalu_after_signing, s, e);
tcase_add_loop_test(tc, remove_two_gop_in_start_of_stream, s, e);
tcase_add_loop_test(tc, camera_reset_on_signing_side, s, e);
tcase_add_loop_test(tc, detect_change_of_public_key, s, e);
tcase_add_loop_test(tc, fast_forward_stream_with_reset, s, e);
Expand Down