Remove reset_gop_hash and update_gop_hash APIs #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These APIs are no longer needed as recursive hash is not used.
mithydolphin
requested review from
bjornvolcker,
lusikamalo and
Caroline-Holmstrom
as code owners
lusikamalo
reviewed
Dec 5, 2024
lib/src/signed_video_h26x_auth.c
Outdated
| @@ -29,9 +29,9 @@ | |||
| #include "legacy_validation.h" | |||
| #include "signed_video_authenticity.h" // create_local_authenticity_report_if_needed() | |||
| #include "signed_video_defines.h" // svrc_t | |||
| #include "signed_video_h26x_internal.h" // gop_state_*(), update_gop_hash(), update_validation_flags() | |||
| #include "signed_video_h26x_internal.h" // gop_state_*() , update_validation_flags() | |||
lusikamalo
reviewed
Dec 5, 2024
lib/src/signed_video_h26x_sign.c
Outdated
| // Reset the gop_hash since we start a new GOP. | ||
| SV_THROW(reset_gop_hash(self)); | ||
| // Reset the |num_nalus_in_gop_hash| since we start a new GOP. | ||
| self->gop_info->num_nalus_in_gop_hash = 0; |
There was a problem hiding this comment.
You already got "gop_info" from row 350.
lusikamalo
requested changes
Dec 5, 2024
bjornvolcker
approved these changes
Dec 5, 2024
bjornvolcker
approved these changes
Dec 5, 2024
| assert(gop_info); | ||
|
|
||
| gop_info->num_nalus_in_gop_hash = 0; | ||
| return openssl_hash_data(self->crypto_handle, &gop_info->gop_hash_init, 1, gop_info->gop_hash); |
There was a problem hiding this comment.
We should write a ticket to init the new gop hash computation with gop_hash_init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These APIs are no longer needed as recursive hash is not used.
Describe your changes
Please include a summary of the change, a relevant motivation and context.
Issue ticket number and link
Checklist before requesting a review