Adds two tests with two useless SEIs #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library is not working for file exports where arbitrary number of useless SEIs are present in the beginning. A useless SEI is a SEI that actually belongs to a snippet of the stream present before the recording. The library can handle one such SEI, but not two. Therefore, this commit adds two tests that have two useless SEIs in the beginning, one for a stream start and one for a file export. The test helper function generate_delayed_sei_list() has been extended with two more GOPs to catch if tests are recovered to produce "valid" outputs.
bjornvolcker
requested review from
lusikamalo,
Caroline-Holmstrom and
mithydolphin
as code owners
mithydolphin
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library is not working for file exports where arbitrary number
of useless SEIs are present in the beginning. A useless SEI is a
SEI that actually belongs to a snippet of the stream present before
the recording.
The library can handle one such SEI, but not two. Therefore, this
commit adds two tests that have two useless SEIs in the beginning,
one for a stream start and one for a file export.
The test helper function generate_delayed_sei_list() has been
extended with two more GOPs to catch if tests are recovered to
produce "valid" outputs.