Implement Readiness service and probes #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored RestServer to start as quick as possible to provide information. Update StreamsQuerier to KsmlQuerier to reflect it able to query multiple Ksml info Update WebService error handling, throwing WebApplicationExceptions like NotFoundException (404) or ServiceUnavailableException(503) returns those error codes Updated store query implementation to return 503 codes if KSML hasn't started yet and 404 if an unknown store name was accessed Removed StoreQuerier.java, as it was not used by any component.
jeroenvandisseldorp
approved these changes
Aug 27, 2024
ksml-query/src/main/java/io/axual/ksml/rest/server/ReadyResource.java
Outdated
Show resolved
Hide resolved
Fix issue that KafkaProducerRunner remained running with no scheduled items Fix issue that KSMLRunner did not stop when both Producer and Streams where done or failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Readiness service has been added to the KSML service, reachable on path
/readyThe helm charts have been updated with default readiness, liveness and startup probes.
The KSML Runner has been updated to start the RestServer as soon as possible to provide the services.
The existing services has been updated to provide Service Unavailable (503) statuses during startup.
Queries to a non existent state store will result in a Not Found (404) status.
The RestServer now handles WebApplicationExceptions explicitly, returning the corresponding status codes
The StreamsQuerier interface has been renamed KsmlQuerier since it also supplies other information.
Removed the StoreQuerier class, as it was not used by any component.