Fix KSML java process not stopping on exception#88
Merged
jeroenvandisseldorp merged 1 commit intoAxual:mainfrom Jan 10, 2024
richard-axual:fix/ksml-not-stopping-on-deserialize-failure
Merged
Fix KSML java process not stopping on exception#88jeroenvandisseldorp merged 1 commit intoAxual:mainfrom richard-axual:fix/ksml-not-stopping-on-deserialize-failure
jeroenvandisseldorp merged 1 commit intoAxual:mainfrom
richard-axual:fix/ksml-not-stopping-on-deserialize-failure
Conversation
…L Java process to keep running
jeroenvandisseldorp
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exception handling of KSML stops the Kafka Streams and other flows, but the executor service is not shut down in this flow.
Moved the KSMLRunner executor service shutdown to the finally block to make sure it is always stopped