Skip to content

Fixed a bug involving user variables #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cioroianudenis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed a bug involving user variables #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/provider.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ module.exports =

if @userSuggestions?
for userVar in @userSuggestions.user_vars when userVar.text.toLowerCase().indexOf(lowerCasePrefix) is 0
completions.push(@buildCompletion(userVar))
completions.push(@buildCompletion(userVar, prefix))

for variable in @completions.variables when variable.text.toLowerCase().indexOf(lowerCasePrefix) is 0
completions.push(@buildCompletion(variable))
Expand Down Expand Up @@ -181,19 +181,20 @@ module.exports =

if @userSuggestions?
for userVar in @userSuggestions.user_vars when userVar.text.toLowerCase().indexOf(lowerCasePrefix) is 0
completions.push(@buildCompletion(userVar))
completions.push(@buildCompletion(userVar, prefix))

for variable in @completions.variables when variable.text.toLowerCase().indexOf(lowerCasePrefix) is 0
completions.push(@buildCompletion(variable))

completions


buildCompletion: (suggestion) ->
buildCompletion: (suggestion, prefix = null) ->
text: suggestion.text
type: suggestion.type
displayText: suggestion.displayText ?= null
snippet: suggestion.snippet ?= null
leftLabel: suggestion.leftLabel ?= null
description: suggestion.description ?= "PHP <#{suggestion.text}> #{suggestion.type}"
descriptionMoreURL: suggestion.descriptionMoreURL ?= null
replacementPrefix: prefix