fix: stop bot in case of tx errors #9421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexghr
force-pushed
the
ag/restart-bot
branch
2 times, most recently
from
0a5d17d
to
cbbce08
Compare
alexghr
force-pushed
the
ag/restart-bot
branch
from
cbbce08
to
465a727
Compare
PhilWindle
requested changes
Oct 27, 2024
| @@ -103,8 +105,8 @@ describe('In-Memory P2P Client', () => { | |||
| await client.start(); | |||
| expect(client.isReady()).toEqual(true); | |||
|
|
|||
| await client.stop(); | |||
| expect(client.isReady()).toEqual(false); | |||
| // await client.stop(); | |||
There was a problem hiding this comment.
Should this be commented out?
| ); | ||
| await this.txPool.deleteTxs(txsToDelete); | ||
| await this.synchedLatestBlockNumber.set(latestBlock); | ||
| await this.synchedProvenBlockNumber.set(latestBlock); |
There was a problem hiding this comment.
I'm not sure we should be setting the synched proven block number here. This should only be done via proven chain events shouldn't it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a couple of fixes for the network occasionally stopping when run for a longer period of time: