-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop bot in case of tx errors #9421
base: master
Are you sure you want to change the base?
Conversation
0a5d17d
to
cbbce08
Compare
cbbce08
to
465a727
Compare
@@ -103,8 +105,8 @@ describe('In-Memory P2P Client', () => { | |||
await client.start(); | |||
expect(client.isReady()).toEqual(true); | |||
|
|||
await client.stop(); | |||
expect(client.isReady()).toEqual(false); | |||
// await client.stop(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be commented out?
); | ||
await this.txPool.deleteTxs(txsToDelete); | ||
await this.synchedLatestBlockNumber.set(latestBlock); | ||
await this.synchedProvenBlockNumber.set(latestBlock); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should be setting the synched proven block number here. This should only be done via proven chain events shouldn't it?
This PR contains a couple of fixes for the network occasionally stopping when run for a longer period of time: