fix(avm): address bytecode hashing comments #9436
Merged
+26
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @IlyasRidhuan and the rest of your teammates on |
IlyasRidhuan
force-pushed
the
ir/09-28-feat_trace_class_id_and_instance
branch
from
5ff45f6
to
3395ccf
Compare
IlyasRidhuan
force-pushed
the
ir/10-25-fix_avm_address_bytecode_hashing_comments
branch
from
2608730
to
1385a08
Compare
|
I'd change or comment the line mentioned here |
IlyasRidhuan
force-pushed
the
ir/09-28-feat_trace_class_id_and_instance
branch
2 times, most recently
from
26249b2
to
b6c741e
Compare
IlyasRidhuan
force-pushed
the
ir/10-25-fix_avm_address_bytecode_hashing_comments
branch
from
1385a08
to
5ce56b4
Compare
Base automatically changed from
ir/09-28-feat_trace_class_id_and_instance
to
master
October 26, 2024 22:26
IlyasRidhuan
force-pushed
the
ir/10-25-fix_avm_address_bytecode_hashing_comments
branch
from
5ce56b4
to
54c1e3d
Compare
IlyasRidhuan
requested review from
fcarreiro,
dbanks12 and
jeanmon
as code owners
dbanks12
approved these changes
Oct 27, 2024
dbanks12
deleted the
ir/10-25-fix_avm_address_bytecode_hashing_comments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing up some earlier comments in PRs