Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for public inputs columns #55

Merged
merged 2 commits into from
May 13, 2024
Merged

feat: support for public inputs columns #55

merged 2 commits into from
May 13, 2024

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Apr 9, 2024

No description provided.

@Maddiaa0 Maddiaa0 marked this pull request as ready for review April 12, 2024 13:54
jeanmon
jeanmon approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@jeanmon jeanmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am wondering if defining a new PilStatement would not have been the cleanest way but very likely more costly.

pil_analyzer/src/statement_processor.rs Outdated Show resolved Hide resolved
parser/src/powdr.lalrpop Outdated Show resolved Hide resolved
@Maddiaa0 Maddiaa0 merged commit 0cab75e into avm May 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanmon jeanmon jeanmon approved these changes

@IlyasRidhuan IlyasRidhuan Awaiting requested review from IlyasRidhuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maddiaa0 @jeanmon