generate row deserialization #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanmon
approved these changes
Jun 10, 2024
bberg/src/circuit_builder.rs
Outdated
| @@ -254,6 +258,60 @@ class {name}CircuitBuilder {{ | |||
| &circuit_hpp, | |||
| ); | |||
| } | |||
|
|
|||
| fn create_circuit_builder_cpp(&mut self, name: &str, all_cols_with_shifts: &[String]) { | |||
There was a problem hiding this comment.
@fcarreiro If this outputs also the "shift columns", I would rather make the inclusion of such columns optional. We will rarely need them. It will be rare that a bug emerges from a malformed shift column.
| @@ -6,7 +6,7 @@ authors = ["Maddiaa"] | |||
| edition = "2021" | |||
|
|
|||
| [[bin]] | |||
| name = "bberg_pil" | |||
| name = "bb_pil" | |||
There was a problem hiding this comment.
I am fine with the renaming but please announce this change in the Slack channel. I have an alias currently pointing to bberg_pil and I would continue to use an old version until it breaks. I do not think that cargo build would clean the old binary.
fcarreiro
force-pushed
the
fc/generate-row-deser
branch
from
01c6916
to
416291b
Compare
fcarreiro
force-pushed
the
fc/generate-row-deser
branch
from
416291b
to
078a08f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for serialization to CSV.