Add .internal file handling from the setup repo
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactor how data urls are obtained
|
would recommend yea to split the node fetch to a separate pull request :) |
|
The .internal files are marked for further transforming IIRC. I'm not sure if we should use them because that is not a fully transformed file. Probably needs additional discussion with @octo-kumo, who is the maintainer of the setup repo. |
|
Either that or they are just marked as internal because it is "unstable". I have no clue tbh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the way data urls are obtained and added node-fetch to have access to the status of the request, so that the
.internalversion of a data file is tried in the case of the initial request returning a 404.The PR is marked as draft as there seem to be some differences in the format of internal files compared to what normal files looked like, I assume, leading to the majority of the tests breaking, such as there being no "IJN" nationality, instead expecting "Sakura Empire". The data format is outside the scope of my knowledge, so someone else should most likely fix these compatibility issues.