Readme improvements #182
Merged
Readme improvements #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisquintanilla
approved these changes
Oct 12, 2023
IEvangelist
pushed a commit
to IEvangelist/azure-search-openai-demo-csharp
that referenced
this pull request
Dec 5, 2023
## Purpose Improve the readme for better clarification on the workflow. Also adding restrictions on the location in Bicep to prevent attempting to deploy to a region that doesn't support OpenAI. ## Does this introduce a breaking change? ``` [ ] Yes [x] No ``` ## Pull Request Type What kind of change does this Pull Request introduce? ``` [ ] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [x] Documentation content changes [ ] Other... Please describe: ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve the readme for better clarification on the workflow. Also adding restrictions on the location in Bicep to prevent attempting to deploy to a region that doesn't support OpenAI.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?