-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to .NET 8 #191
Upgrade to .NET 8 #191
Conversation
Thanks @IEvangelist |
Sounds good @IEvangelist. Thanks. Which parts from #186 are not in this PR? |
I noticed that this PR also upgrades to C# 12 preview - I'd suggest not doing that in this PR but in a follow-up one to ensure that it's easier to review the .NET 8 specific changes without also having language changes in there. Small and targeted PRs are easier to review and remediate. |
@LittleLittleCloud do these changes affect the App Insight / Authentication changes you've made? |
@luisquintanilla Shouldn't be effected. |
Cool. Let's merge those in first then and do a quick test and follow of these changes. |
I'd merge #184 first as the changes it introduces are unrelated to the .NET 8 upgrade, so it would give better history tracking of when/why changes were made. |
I just now saw Azure-Samples#186, I didn't realize before that there was an effort in place to do this work. There are parts of that PR that look good—@luisquintanilla how should we proceed? I pulled in the changes from the PR that I liked. ~Let's add the CPM in a separate PR, since versions weren't bumped~. I've bumped the versions, and I'm updating this PR to utilize the CPM feature since it does improve the `PacakgeReference` experience. --------- Co-authored-by: XiaoYun Zhang <xiaoyuz@microsoft.com>
I just now saw #186, I didn't realize before that there was an effort in place to do this work. There are parts of that PR that look good—@luisquintanilla how should we proceed?
I pulled in the changes from the PR that I liked.
Let's add the CPM in a separate PR, since versions weren't bumped.I've bumped the versions, and I'm updating this PR to utilize the CPM feature since it does improve the
PacakgeReference
experience.