Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment fixes #287

Merged

Conversation

SvenAelterman
Copy link
Contributor

@SvenAelterman SvenAelterman commented Feb 21, 2024

Purpose

Closes #286 (Fix default value for azureOpenAIChatGptModelName)
Closes #287 (Fix bash script if nesting)
Closes #289 (Fix bash script including ' in files argument value)

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]

Open in devcontainer

  • Test the code
azd up

What to Check

Verify that the following are valid

  • Deployment succeeds

@SvenAelterman SvenAelterman changed the title Fix default value for azureOpenAIChatGptModelName Deployment fixes Feb 21, 2024
@SvenAelterman SvenAelterman marked this pull request as draft February 21, 2024 03:29
@SvenAelterman SvenAelterman marked this pull request as ready for review February 21, 2024 05:18
@LittleLittleCloud
Copy link
Collaborator

@SvenAelterman Thanks for the fixing PR

@LittleLittleCloud LittleLittleCloud merged commit 52d0265 into Azure-Samples:main Feb 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants