Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core AZD bicep modules from the official repo #324

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

FBoucher
Copy link
Contributor

@FBoucher FBoucher commented May 27, 2024

Purpose

Refreshing bicep files using official AZD templates.

@FBoucher FBoucher marked this pull request as ready for review June 5, 2024 20:40
@tonybaloney tonybaloney changed the title Improve security Update core AZD bicep modules from the official repo Jun 6, 2024
@tonybaloney tonybaloney self-requested a review June 6, 2024 00:32
@FBoucher
Copy link
Contributor Author

FBoucher commented Jun 7, 2024

It was like this. The documentation could be more explicit, but looking at the bicep files it looks like it will use an existing OpenAI service with this key if provided. If let empty the provisioning will create an Azure openAI service and use that one.

@FBoucher
Copy link
Contributor Author

@tonybaloney should I do something more?

@Azure-Samples Azure-Samples deleted a comment from hatefulbitch7 Jun 12, 2024
@tonybaloney tonybaloney merged commit bb5d3f4 into Azure-Samples:main Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants