-
Notifications
You must be signed in to change notification settings - Fork 551
feat: Support rbac auth type in conversation_logger #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@microsoft-github-policy-service agree |
Coverage Report •
|
@Prasanjeet-Microsoft and @Vinay-Microsoft I have committed a better fix for this issue and rebased my recent changes on it, so it is in sync with the upstream main. |
Hello @leonavevor, Thanks for the updated fix and for incorporating the changes using the AzureSearch library. We will verify the changes and if everything works as expected, we will proceed with merging the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Purpose
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information