Fix duplicate copy warning alert #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecheta
reviewed
Jan 24, 2024
| @@ -14,11 +14,13 @@ import supersub from 'remark-supersub' | |||
| interface Props { | |||
| answer: AskResponse; | |||
| onCitationClicked: (citedDocument: Citation) => void; | |||
| index: Number; | |||
There was a problem hiding this comment.
Suggested change
| index: Number; | |
| index: number; |
| @@ -57,15 +59,16 @@ export const Answer = ({ | |||
| const handleCopy = () => { | |||
| alert("Please consider where you paste this content."); | |||
| }; | |||
| document.addEventListener("copy", handleCopy); | |||
| var messageBox = document.getElementById("message-" + index); | |||
There was a problem hiding this comment.
Suggested change
| var messageBox = document.getElementById("message-" + index); | |
| const messageBox = document.getElementById("message-" + index); |
| @@ -57,15 +59,16 @@ export const Answer = ({ | |||
| const handleCopy = () => { | |||
| alert("Please consider where you paste this content."); | |||
| }; | |||
| document.addEventListener("copy", handleCopy); | |||
| var messageBox = document.getElementById("message-" + index); | |||
There was a problem hiding this comment.
Maybe define "message-" + index as a variable then use it in both places
Also can use a template string
- It was being added to the whole page everytime an answer was returned - This meant that if **any** content on the page was copied the alert was being shown multiple times based on how many answers there had been - This change will mean the alert will now only be shown when an answer is copied and only once Required by Azure-Samples#215
adamdougal
force-pushed
the
bugfix/duplicate-copy-alert
branch
from
5197f25 to
384833a
Compare
eduardogch
pushed a commit
to devopsdale/chat-with-your-data-solution-accelerator
that referenced
this pull request
Apr 30, 2024
* Fix duplicate copy warning alert - It was being added to the whole page everytime an answer was returned - This meant that if **any** content on the page was copied the alert was being shown multiple times based on how many answers there had been - This change will mean the alert will now only be shown when an answer is copied and only once Required by Azure-Samples#215 * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Required by #215
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information