Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pre-commit hook #244

Merged
merged 9 commits into from
Feb 1, 2024
Merged

Add Pre-commit hook #244

merged 9 commits into from
Feb 1, 2024

Conversation

ross-p-smith
Copy link
Collaborator

Purpose

This work is Dependent on #243 hitting main first

  • Split the requirements out into separate files for development (pytest/flake/black/etc)
  • Add a pre-commit hook to run flake and black

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Rebuild devcontainer
  • Make a bad formatting change (extra space at the end of a line)
  • Try and commit and warning should appear

@ross-p-smith ross-p-smith changed the title Ross/dev requirements Add Pre-commit hook Jan 30, 2024
@ross-p-smith ross-p-smith self-assigned this Jan 31, 2024
@ross-p-smith ross-p-smith requested a review from cecheta February 1, 2024 13:21
cecheta
cecheta approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@cecheta cecheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ross-p-smith ross-p-smith added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 2c29aea Feb 1, 2024
3 checks passed
@ross-p-smith ross-p-smith deleted the ross/dev-requirements branch February 1, 2024 14:25
eduardogch pushed a commit to devopsdale/chat-with-your-data-solution-accelerator that referenced this pull request Apr 30, 2024
@ross-p-smith
Add Pre-commit hook (Azure-Samples#244)
5e462a0 
* Move tests to root

* Pre-Commit Hook

* remove pytest.ini

* Add dev requirements to build

* Add contributing guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecheta cecheta cecheta approved these changes

@adamdougal adamdougal Awaiting requested review from adamdougal

Assignees

@ross-p-smith ross-p-smith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ross-p-smith @adamdougal @cecheta