Skip to content

Simple CI for Pull Requests #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 1, 2024
Merged

Simple CI for Pull Requests #247

merged 8 commits into from
Feb 1, 2024

Conversation

ross-p-smith
Copy link
Collaborator

@ross-p-smith ross-p-smith commented Jan 30, 2024 •
edited
Loading

Purpose

Currently the repository only runs basic unit tests on a Pull Request. There is no way to know whether the typescript front end compiles or the python apps work.

This PR is an initial start to improve that process. For each PR the following steps will be carrried out.

  • Pull the code
  • Login to GitHub Container Registry
  • Pull a cached dev container
  • Build the dev container (using the cache)
  • Run make commands inside the devcontainer - this means anything you can run in the devcontainer will run in the build. We currently run make ci
  • If we are on main then push the new devcontainer image

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x] Other... Please describe: CI

What to Check

When a PR is created the CI workflow runs

@ross-p-smith ross-p-smith mentioned this pull request Jan 30, 2024
Closed
6 tasks
@ross-p-smith ross-p-smith marked this pull request as ready for review January 30, 2024 21:41
adamdougal
adamdougal reviewed Jan 31, 2024
View reviewed changes
cecheta
cecheta reviewed Jan 31, 2024
View reviewed changes
@ross-p-smith ross-p-smith self-assigned this Jan 31, 2024
@ross-p-smith ross-p-smith added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 88cff26 Feb 1, 2024
@ross-p-smith ross-p-smith deleted the ross/ci branch February 1, 2024 11:40
eduardogch pushed a commit to devopsdale/chat-with-your-data-solution-accelerator that referenced this pull request Apr 30, 2024
@ross-p-smith
Simple CI for Pull Requests (Azure-Samples#247)
b6a2b29 
* Basic CI on PR

* Add workflow dispatch whilst testing

* Remove status action

* Filter for push

* Add single ci target

* Restrictive permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecheta cecheta cecheta approved these changes

@superhindupur superhindupur Awaiting requested review from superhindupur

@komalg1 komalg1 Awaiting requested review from komalg1

@adamdougal adamdougal Awaiting requested review from adamdougal

Assignees

@ross-p-smith ross-p-smith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ross-p-smith @adamdougal @cecheta