Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully azdevify the application #281
Fully azdevify the application #281
Changes from 60 commits
24be759
fbfd9b7
d32d977
552f254
c00f55a
b2e62b2
b1a97b7
625487e
65ac3c5
43b09e7
bd29d31
8587450
afd3ca8
654762e
cc3e957
9dc6a78
9bcb2a7
1a9212b
eb11eab
a403d25
b88ee5f
4bdf8c3
1ecb9be
75f230e
969aa25
ffee3f8
778e1d4
5892d5d
ce7d48d
2b683de
397ab11
1e21f2a
9481a66
b25cce5
332402a
bd092df
5406c5a
d2145ec
c83a409
aa86081
06bb879
1a7303a
2c8abfb
5dcf10c
779065f
cf07644
5186832
7ac0727
7ac4e5f
b769b9a
5c85d84
c4e140d
9b6f180
4a1ef31
97eb155
1701d36
49ddafd
9087ebe
984b7a8
fab8895
2d92b83
4167b63
32c5851
792c7f8
61f85bf
ce0279d
6d7bb5a
76d5b74
56caa4c
f3abef6
1f6572e
215af4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of a nit. But for me, it took 35 minutes for this to fully deploy. Should we re-word this to set better expectations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jongio - Three services are currently used. In local deployment, we also noticed that packaging in
python
andnpm
takes a lot of time. In fact,adminweb
andfunction
services use the samerequirements.txt
file, but when using azd to deploy, because two independent services need to install packages twice, the deployment time is too long. Do you have any suggestions for optimizing deployment time?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you have a step that installs the requirements first and then uses a multi-stage docker build step that shares the locations of the packages?
The devcontainer installs all of these requirements as a PostCreate step so as long as we use a convention we can fix it for this too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ross-p-smith - If I understand correctly, you mean to install the required
requirements
in a container first, and then use docker to obtain them in other containers where they are needed, right?@jongio - Do you have any ideas about the above requirements? As far as I know, when using
azd deploy
, thehost=appservice
withlanguage=py
will first find the requirements in the current path and install it. And usingazd
, the process from provisioning resources to deploying resources is consistent. If we want to pull other images in appservice, it seems that we can only do some operations through theappCommandLine
parameter during provisioning (docker has been installed in appservice). What do you think about this? Or do you have better optimization suggestions?