Upgrade langchain #450
Merged
Upgrade langchain #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report •
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
ross-p-smith
commented
Mar 18, 2024
infra/main.bicep
Outdated
There was a problem hiding this comment.
The changes here are just order
ross-p-smith
requested review from
adamdougal,
komalg1,
superhindupur and
cecheta
adamdougal
reviewed
Mar 19, 2024
|
|
||
|
|
||
| class Testing_LangChainAgent(LangChainAgent): | ||
| def __init__(self) -> None: |
There was a problem hiding this comment.
Nice way of overriding values when you can't provide them via the constructor! Do we need to call super().__init__() here though? I can see we're doing it in a few places, including the LangChainAgent,
There was a problem hiding this comment.
If I call super.__init then I will also create a whole set of connected server objects which makes it hard to test. The idea was to not initialise the base class and just to test these two methods.
cecheta
reviewed
Mar 19, 2024
Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com>
cecheta
approved these changes
Mar 19, 2024
superhindupur
pushed a commit
that referenced
this pull request
Mar 20, 2024
* Upgrade langchain * Had to upgradeOpenAi * Add a few langchain agent tests * Upgrade langchain_openai * Ordered config alphabetically * Missing lock file * Removing AZURE_OPENAI_KEY * Fix LLM Helper * we dont have that env set anymore - so we dont need to delete * remove comment * Update .gitignore Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com> --------- Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com>
eduardogch
pushed a commit
to devopsdale/chat-with-your-data-solution-accelerator
that referenced
this pull request
Apr 30, 2024
* Upgrade langchain * Had to upgradeOpenAi * Add a few langchain agent tests * Upgrade langchain_openai * Ordered config alphabetically * Missing lock file * Removing AZURE_OPENAI_KEY * Fix LLM Helper * we dont have that env set anymore - so we dont need to delete * remove comment * Update .gitignore Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com> --------- Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Both
langchainandlangchain-communityneeded upgrading.langchain-communityneeds to uselangchain-openaiand then this causes us to upgrade the version ofopenai.The new versions of these packages no longer use the environment variable OPENAI_API_BASE, but rather insist on using AZURE_OPENAI_ENDPOINT
I have re-ordered the environment variables in the bicep files so that they are a bit easier to see and find.
Relates to #417
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?