Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable report-only-changed-files for forks #453

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Disable report-only-changed-files for forks #453

merged 1 commit into from
Mar 18, 2024

Conversation

cecheta
Copy link
Collaborator

@cecheta cecheta commented Mar 18, 2024

Purpose

  • Due to a bug in the action, report-only-changed-files does not work for PRs from forks, therefore disable this for now until fixed. Note that the action still works and posts successfully, however the workflow exits with an error.

image

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Tested in fork

@github-actions GitHub Actions
Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL1626107433% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
27 0 💤 0 ❌ 0 🔥 6.297s ⏱️

@ross-p-smith ross-p-smith added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 92435a0 Mar 18, 2024
2 checks passed
@ross-p-smith ross-p-smith deleted the coverage-fork branch March 18, 2024 13:14
eduardogch pushed a commit to devopsdale/chat-with-your-data-solution-accelerator that referenced this pull request Apr 30, 2024
@cecheta
Disable report-only-changed-files for forks (Azure-Samples#453)
e4c173c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ross-p-smith ross-p-smith ross-p-smith approved these changes

@adamdougal adamdougal Awaiting requested review from adamdougal

@superhindupur superhindupur Awaiting requested review from superhindupur

@komalg1 komalg1 Awaiting requested review from komalg1

@tanya-borisova tanya-borisova Awaiting requested review from tanya-borisova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cecheta @ross-p-smith