Upgrade keyvault secrets library #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
ross-p-smith
requested review from
adamdougal and
jongio
and removed request for
jongio
cecheta
reviewed
Mar 20, 2024
Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com>
cecheta
approved these changes
Mar 20, 2024
superhindupur
pushed a commit
that referenced
this pull request
Mar 20, 2024
* Upgrade keyvault secrets library * Add comment in test * typo! * Mock SecretClient (#483) Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com> --------- Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com>
eduardogch
pushed a commit
to devopsdale/chat-with-your-data-solution-accelerator
that referenced
this pull request
Apr 30, 2024
* Upgrade keyvault secrets library * Add comment in test * typo! * Mock SecretClient (Azure-Samples#483) Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com> --------- Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upgrade the KeyVault library. Cleanest way to test this was to ensure that we wrote a helper method that encapsulated the SecretClient so that it could be tested.
Also found some areas that should have been using the new AZURE_OPENAI_ENDPOINT env that langchain demands.
Renamed the
Testing_LangChainAgentclass so that pytest doesn't try and collect itRelates to #417
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?