Functional tests for /azure_byod #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecheta
requested review from
adamdougal,
superhindupur,
ross-p-smith,
komalg1 and
tanya-borisova
Coverage Report •
|
adamdougal
reviewed
Apr 4, 2024
eduardogch
pushed a commit
to devopsdale/chat-with-your-data-solution-accelerator
that referenced
this pull request
Apr 30, 2024
* Functional tests for /azure_byod * Split tests into two * Refactor + README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264 , closes #553
Purpose
/api/conversation/azure_byodendpoint, both when using data and when not using data.In order to do this, it was necessary to launch the application a second time with different environment variables, to distinguish between using data and not using data. There is a refactor of the existing code to accommodate this, mainly that a number of fixtures are changed to
packagescope, so they cleanup after the tests in that package have finished running. There is duplication between fixtures in the two packages, I wasn't sure how to avoid this while still ensuring that the fixtures cleaned up after running in each package.Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
poetry run pytest -m "not azure"