-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR for using Pull based(Integrated Vectorization) approach throughout #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the initial draft design I thought of for implementing Integrated Vectorization. I might have missed something. We can have an extended discussion and finalize the design. |
komalg1
requested review from
adamdougal,
ross-p-smith,
tanya-borisova and
cecheta
April 8, 2024 16:36
ross-p-smith
reviewed
Apr 8, 2024
docs/design/adrs/2024-04-08-push-vs-pull-approach-for-search.md
Outdated
Show resolved
Hide resolved
ross-p-smith
reviewed
Apr 8, 2024
docs/design/adrs/2024-04-08-push-vs-pull-approach-for-search.md
Outdated
Show resolved
Hide resolved
adamdougal
reviewed
Apr 9, 2024
docs/design/adrs/2024-04-08-push-vs-pull-approach-for-search.md
Outdated
Show resolved
Hide resolved
docs/design/adrs/2024-04-08-push-vs-pull-approach-for-search.md
Outdated
Show resolved
Hide resolved
docs/design/adrs/2024-04-08-push-vs-pull-approach-for-search.md
Outdated
Show resolved
Hide resolved
docs/design/adrs/2024-04-08-push-vs-pull-approach-for-search.md
Outdated
Show resolved
Hide resolved
docs/design/adrs/2024-04-08-push-vs-pull-approach-for-search.md
Outdated
Show resolved
Hide resolved
komalg1
changed the title
ADR for options available for using pull based approach (Integrated Vectorization)
ADR for using Pull based(Integrated Vectorization) approach throughout
Apr 10, 2024
adamdougal
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! One minor comment!
docs/design/adrs/2024-04-08-use-pull-throughout-for-ingestion.md
Outdated
Show resolved
Hide resolved
docs/design/adrs/2024-04-08-use-pull-throughout-for-ingestion.md
Outdated
Show resolved
Hide resolved
17 tasks
docs/design/adrs/2024-04-08-use-pull-throughout-for-ingestion.md
Outdated
Show resolved
Hide resolved
docs/design/adrs/2024-04-08-use-pull-throughout-for-ingestion.md
Outdated
Show resolved
Hide resolved
docs/design/adrs/2024-04-08-use-pull-throughout-for-ingestion.md
Outdated
Show resolved
Hide resolved
cecheta
previously approved these changes
Apr 18, 2024
ross-p-smith
previously approved these changes
Apr 18, 2024
cecheta
reviewed
Apr 18, 2024
docs/design/adrs/2024-04-08-use-pull-throughout-for-ingestion.md
Outdated
Show resolved
Hide resolved
cecheta
approved these changes
Apr 18, 2024
superhindupur
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?