Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more metrics and logs to workbook #630

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

adamdougal
Copy link
Collaborator

  • This required templating resource names
  • Extracted resources to hidden params to reduce templating effort
  • Let me know if you want a link to a working example

Required by #418

Copy link

github-actions bot commented Apr 8, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL165095242% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
48 0 💤 0 ❌ 0 🔥 10.083s ⏱️

infra/main.bicep Outdated Show resolved Hide resolved
@adamdougal adamdougal mentioned this pull request Apr 9, 2024
5 tasks
@adamdougal adamdougal requested a review from ross-p-smith April 9, 2024 09:43
- This required templating resource names
- Extracted resources to hidden params to reduce templating effort
- Let me know if you want a link to a working example

Required by #418
@adamdougal adamdougal force-pushed the adam/418-add-to-workbook branch from 896fc97 to c08672d Compare April 9, 2024 13:31
@adamdougal adamdougal added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit 7af0de9 Apr 9, 2024
5 checks passed
@adamdougal adamdougal deleted the adam/418-add-to-workbook branch April 9, 2024 16:07
eduardogch pushed a commit to devopsdale/chat-with-your-data-solution-accelerator that referenced this pull request Apr 30, 2024
* Add more metrics and logs to workbook

- This required templating resource names
- Extracted resources to hidden params to reduce templating effort
- Let me know if you want a link to a working example

Required by Azure-Samples#418

* Extract workbook logic into a separate module

* Use resources directly to retrieve names

* Fix main.json after merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants