-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for backend functions #644
Merged
tanya-borisova
merged 22 commits into
main
from
584-add-unit-tests-for-the-batch-function-app
Apr 15, 2024
Merged
Add test for backend functions #644
tanya-borisova
merged 22 commits into
main
from
584-add-unit-tests-for-the-batch-function-app
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olution-accelerator into 584-add-unit-tests-for-the-batch-function-app
Coverage Report •
|
…b.com:Azure-Samples/chat-with-your-data-solution-accelerator into 584-add-unit-tests-for-the-batch-function-app
cecheta
reviewed
Apr 11, 2024
cecheta
requested changes
Apr 11, 2024
Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com>
The tests are quite slow, I think we need to mock |
adamdougal
reviewed
Apr 11, 2024
tanya-borisova
changed the title
Add test for batch processing function
Add test for backend functions
Apr 12, 2024
…olution-accelerator into 584-add-unit-tests-for-the-batch-function-app
cecheta
reviewed
Apr 12, 2024
cecheta
reviewed
Apr 12, 2024
…b.com:Azure-Samples/chat-with-your-data-solution-accelerator into 584-add-unit-tests-for-the-batch-function-app
adamdougal
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
cecheta
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
tanya-borisova
deleted the
584-add-unit-tests-for-the-batch-function-app
branch
April 15, 2024 09:06
eduardogch
pushed a commit
to devopsdale/chat-with-your-data-solution-accelerator
that referenced
this pull request
Apr 30, 2024
* Add test for batch processing function * Remove comment * Try to remove sys path modifications * Fix imports * Fix sys path append statements by making paths absolute * Remove extra sys.path.append that isnt necessary * Apply suggestions from code review Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com> * Rename test file, add a test for no url in request * Make sure ConfigHelper etc are mocked out * Mock out config helper * Improve sys.path.append * Mock EnvHelper as well to speed up test execution time * Utilise get_user_function() method to enable tests * re-add env sample * Init log level from os environ --------- Co-authored-by: Chinedum Echeta <60179183+cecheta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?