Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make backend search, backend tools and remainder backend files PEP8 compliant #899

Merged
merged 9 commits into from
May 14, 2024

Conversation

gaurarpit
Copy link
Contributor

@gaurarpit gaurarpit commented May 14, 2024

Purpose

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
  • Run the tests:
poetry run pytest -m "not azure and not functional"    
poetry run pytest -m "functional"  

SCR-20240514-mdvv-2

SCR-20240514-mdlu-2

SCR-20240514-mdof-2

SCR-20240514-mdqf-2

What to Check

  • Verify all options work

@gaurarpit gaurarpit self-assigned this May 14, 2024
@gaurarpit gaurarpit changed the title change backend files and 4-pages refactor: change backend files and 4-pages May 14, 2024
Copy link

github-actions bot commented May 14, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend
   admin.py21210%1–5, 7, 9–10, 12, 15–16, 18–19, 22, 29, 36, 39–41, 43, 45
code/backend/batch
   add_url_embeddings.py470100% 
   batch_push_results.py250100% 
   batch_start_processing.py260100% 
   function_app.py16160%1–8, 10, 12–13, 15, 18–21
   get_conversation_response.py320100% 
code/backend/batch/utilities/common
   answer.py24195%39
   source_document.py60591%44, 47, 51, 55, 128
code/backend/batch/utilities/document_chunking
   document_chunking_base.py10280%10, 16
   fixed_size_overlap.py190100% 
   layout.py190100% 
   page.py170100% 
   paragraph.py9277%9, 15
code/backend/batch/utilities/document_loading
   document_loading_base.py9188%13
   layout.py12558%9, 12–13, 16, 25
   read.py12558%9, 12–13, 16, 25
   web.py19194%23
   word_document.py251348%11–12, 22–24, 27, 30, 33–37, 45
code/backend/batch/utilities/helpers/embedders
   integrated_vectorization_embedder.py36488%20, 39–41
   push_embedder.py460100% 
code/backend/batch/utilities/integrated_vectorization
   azure_search_datasource.py190100% 
   azure_search_index.py350100% 
   azure_search_indexer.py230100% 
   azure_search_skillset.py220100% 
code/backend/batch/utilities/loggers
   conversation_logger.py362822%8, 11–12, 15–24, 27–30, 33–42, 46
code/backend/batch/utilities/orchestrator
   lang_chain_agent.py601968%21–24, 26, 61–62, 82–85, 102–103, 106–109, 116–117
   open_ai_functions.py543633%62, 64, 70–73, 75, 78, 85–89, 93–94, 96, 102–106, 110–112, 115, 118–119, 122, 127–129, 132–134, 137, 142
   orchestrator_base.py50884%33, 72–74, 81–83, 93
   semantic_kernel.py540100% 
code/backend/batch/utilities/parser
   output_parser_tool.py390100% 
   parser_base.py9277%9, 19
code/backend/batch/utilities/plugins
   chat_plugin.py150100% 
   post_answering_plugin.py80100% 
code/backend/batch/utilities/search
   azure_search_handler.py58296%24, 30
   integrated_vectorization_search_handler.py61395%35, 111, 120
   search.py13192%15
   search_handler_base.py361363%13–15, 18–20, 24, 28, 32, 36, 40, 44, 48
code/backend/batch/utilities/tools
   answer_processing_base.py8275%8, 12
   answering_tool_base.py9277%9, 15
   content_safety_checker.py412539%16, 18–19, 24, 30–32, 35–36, 42–43, 49–54, 57–59, 61, 65–67, 69
   post_prompt_tool.py221340%11, 14–15, 17–18, 22, 29, 36–37, 45, 51–52, 60
   question_answer_tool.py610100% 
   text_processing_tool.py16943%9, 12–15, 21, 23, 30, 37
code/backend/pages
   02_Explore_Data.py26260%1–7, 9–10, 12, 18, 25, 28, 36, 38–39, 41–44, 46–49, 52–53
   03_Delete_Data.py36360%1–7, 9–11, 13, 19, 26, 29, 37, 39–40, 42–45, 47, 49–50, 54, 58–62, 64, 67–68, 70–72
TOTAL231267370% 

Tests Skipped Failures Errors Time
183 0 💤 0 ❌ 0 🔥 13.498s ⏱️

@gaurarpit gaurarpit changed the title refactor: change backend files and 4-pages refactor: Make backend search, backend tools and remainder backend files PEP8 compliant May 14, 2024
@gaurarpit gaurarpit marked this pull request as ready for review May 14, 2024 12:40
@gaurarpit gaurarpit enabled auto-merge May 14, 2024 12:42
@gaurarpit gaurarpit added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 3b4c2e3 May 14, 2024
9 checks passed
@gaurarpit gaurarpit deleted the arpit/refactor/remainder-backend-pep8 branch May 14, 2024 14:06
liammoat pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make backend search, backend tools and remainder backend files PEP8 compliant
2 participants