Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Keep the Admin.py as uppercase naming to allow the streamlit pick it as is. #912

Merged
merged 2 commits into from
May 15, 2024
Merged

fix: Keep the Admin.py as uppercase naming to allow the streamlit pick it as is. #912

merged 2 commits into from
May 15, 2024

Conversation

gaurarpit
Copy link
Contributor

Purpose

  • Fix the application right now by having Admin.py as is.

Does this introduce a breaking change?

  • Yes
  • No

@gaurarpit gaurarpit self-assigned this May 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend
   Admin.py21210%1–5, 7, 9–10, 12, 15–16, 18–19, 22, 29, 36, 39–41, 43, 45
TOTAL238367371% 

Tests Skipped Failures Errors Time
194 0 💤 0 ❌ 0 🔥 12.514s ⏱️

@gaurarpit gaurarpit marked this pull request as ready for review May 15, 2024 09:45
@gaurarpit gaurarpit enabled auto-merge May 15, 2024 09:56
@cecheta cecheta disabled auto-merge May 15, 2024 10:09
cecheta
cecheta requested changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@cecheta cecheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the PR title to be more descriptive, it will end up on the changelog

@gaurarpit gaurarpit changed the title fix: fix main for now - temporarily fix: Keep the Admin.py as uppercase naming to allow the streamlit pick it as is. May 15, 2024
@gaurarpit
Copy link
Contributor Author

Could you change the PR title to be more descriptive, it will end up on the changelog

Updated. thanks. good shout.

cecheta
cecheta approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@cecheta cecheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gaurarpit gaurarpit enabled auto-merge May 15, 2024 14:40
@gaurarpit gaurarpit added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 4150955 May 15, 2024
9 checks passed
@gaurarpit gaurarpit deleted the arpit/fix/fix-main-temporarily branch May 15, 2024 14:45
@frtibble frtibble mentioned this pull request May 15, 2024
Closed
liammoat pushed a commit that referenced this pull request May 16, 2024
@gaurarpit @liammoat
fix: Keep the Admin.py as uppercase naming to allow the streamlit pic…
8762f24 
…k it as is. (#912)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecheta cecheta cecheta approved these changes

@superhindupur superhindupur superhindupur approved these changes

Assignees

@gaurarpit gaurarpit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaurarpit @superhindupur @cecheta