Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observability - Helm chart releases #63

Merged
merged 39 commits into from
Sep 29, 2023
Merged

Observability - Helm chart releases #63

merged 39 commits into from
Sep 29, 2023

Conversation

katriendg
Copy link
Contributor

@katriendg katriendg commented Sep 7, 2023

  • New helm chart OtelCollection (Opentelemetry collector, fluentbit)
  • New helm chart EdgeObservability: for level 4 with data stores Tempo, Jaeger, Prometheus, and Grafana UI for local visualization on edge
  • Changes to existing charts:
    • DNSMasqAks - additional custom domains
    • Envoy: expose Prometheus for self metrics endpoint, add Otel Collector filter and cluster (for child clusters)
    • Workloads L2 and L4 - Dapr additional config for tracing and metrics
    • Mosquitto - logging
  • GitHub Helm release workflow updates to allow for chart dependencies in release flow

Note this PR has more detailed documentation (part of a forthcoming PR): https://github.com/katriendg/distributed-az-edge-framework/blob/observability/docs/observability.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Workflow trigger

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Chart version updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Chart dependencies

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Observability - new Otel and Grafana helm #61

* Dashboard update

* GH worklow updates

* Existing helm charts changes to take in observability

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Observability - new Otel and Grafana helm #61

* GH worklow simplify helm

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Observability - new Otel and Grafana helm #61

* GH worklow simplify helm

* Typo in workflow

* Helm chart minor updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Observability - new Otel and Grafana helm #61
* Observability - new Otel and Grafana helm #61

* Dashboard update

* GH worklow updates

* Chart version updates

* Chart dependencies

* Updated existing charts for observability

* Updated release workflow

* GH worklow simplify helm

* Typo in workflow

* Helm chart minor updates

* Helm chart releaser workflow updates

* Helm chart releaser CR
Copy link
Contributor

@bindsi bindsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Katrien...unbelievable you kept the overview with all those settings in yaml files :-)

@bindsi bindsi self-requested a review September 21, 2023 07:00
@bindsi bindsi self-requested a review September 21, 2023 07:03
bindsi
bindsi previously approved these changes Sep 21, 2023
Copy link
Contributor

@bindsi bindsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Katrien and unbelievable you kept the overview for those settings in that jungle of yaml files

Copy link
Contributor

@suneetnangia suneetnangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some serious amount of changes and improvements in this PR re observability ❤️ , but does require a significant intake of caffeine during the review process ☕.
Two overarching observations/requests here where possible: aim for smaller iterative changes/PR where possible and a diagram showing these new observability components would be extremely useful for showing a bigger picture (unless it's there and I missed?).

@katriendg katriendg added the enhancement New feature or request label Sep 28, 2023
@katriendg katriendg merged commit a534e25 into Azure-Samples:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants