Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DNS name unique for each deployment #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glahaye
Copy link

@glahaye glahaye commented May 7, 2023

Purpose

  • More than a single ACI deployment can live in each region with this change

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
  • Deploy to multiple resource groups within the same region

@tawalke
Copy link
Contributor

tawalke commented May 8, 2023

This may be already covered in ARM template using function to add to name within character restriction which was reviewed previously. Will verify this is the case for both the ARM & bicep template.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants