feat: implement GET /documents (closes #18) #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaucia86
reviewed
Mar 29, 2024
| @@ -4,7 +4,7 @@ | |||
| "azureFunctions.projectLanguage": "TypeScript", | |||
| "azureFunctions.projectRuntime": "~4", | |||
| "debug.internalConsoleOptions": "neverOpen", | |||
| "azureFunctions.projectLanguageModel": 4, | |||
| "azureFunctions.projectLanguageModel": 3, | |||
There was a problem hiding this comment.
Are we really going to change it to 3? Because I remember we used to change versions for debugging purposes, right?
There was a problem hiding this comment.
Yes, until the issue with the extension is fixed it's best to use the working version
glaucia86
reviewed
Mar 29, 2024
| return Buffer.concat(chunks); | ||
| } | ||
|
|
||
| app.get('documents', { |
There was a problem hiding this comment.
if you wish, here I can separate and place this route in the index.ts in the root of the api folder when I do the Protocol PR
There was a problem hiding this comment.
I just readed the comment above now. Ok. Let's keep it this way. In the next PR for Protocol I will change the chat api and then the .md files in the tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
@glaucia86 I extracted the api declaration from
packages/api/src/index.tsto keep everything in the function to keep the code simpler as we discussed (chat can be done later).Just to reiterate: what you did initially is the best practice that should be used for larger projects, this is only done to keep the projet simpler 🙂 .
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?