Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: icons not showing in safari #39

Merged
merged 5 commits into from
Apr 10, 2024
Merged

fix: icons not showing in safari #39

merged 5 commits into from
Apr 10, 2024

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Apr 10, 2024 •
edited
Loading

Purpose

Oops, some fixes got lost in my stashes!

  • Missing doc on powershell
  • Icon fix for Safari
  • Rename file for Learn indexation

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@sinedied sinedied requested a review from glaucia86 April 10, 2024 07:04
@sinedied sinedied mentioned this pull request Apr 10, 2024
Merged
1 task
glaucia86
glaucia86 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sinedied sinedied merged commit 782d963 into main Apr 10, 2024
5 checks passed
@sinedied sinedied deleted the fixes branch April 10, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinedied @glaucia86