Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement managed identity (closes #56) #58

Merged
merged 21 commits into from
Apr 30, 2024
Merged

Conversation

sinedied
Copy link
Contributor

Purpose

  • Add full managed identity support
  • Switch the vector DB to Azure AI Search (as Azure CosmosDB for MongoDB vCore currently doesn't support Managed Identity)

Previous code using API keys and Azure CosmosDB for MongoDB vCore has been branched here: https://github.com/Azure-Samples/serverless-chat-langchainjs/tree/mongodb-vcore

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

infra/core/ai/cognitiveservices.bicep Dismissed Show dismissed Hide dismissed
@sinedied sinedied requested a review from glaucia86 April 30, 2024 13:35
@sinedied sinedied marked this pull request as ready for review April 30, 2024 13:35
Copy link
Contributor

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sinedied sinedied merged commit d7c7a29 into main Apr 30, 2024
7 checks passed
@sinedied sinedied deleted the managed-identity branch April 30, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants