Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a custom role for accessing batch account #20

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add a custom role for accessing batch account #20

wants to merge 3 commits into from

Conversation

sushilkm
Copy link
Contributor

@sushilkm sushilkm commented Apr 20, 2022 •
edited
Loading

Fixes #23

mandarinamdar
mandarinamdar reviewed Apr 21, 2022
View reviewed changes
Copy link
Member

@mandarinamdar mandarinamdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we dont need a contributor role now, we need to update that in README too

@sushilkm
Copy link
Contributor Author

If we dont need a contributor role now, we need to update that in README too

Done.

@sushilkm sushilkm closed this Apr 21, 2022
@sushilkm sushilkm reopened this Apr 21, 2022
@mandarinamdar mandarinamdar added the enhancement New feature or request label Apr 22, 2022
karthick-rn
karthick-rn approved these changes May 4, 2022
View reviewed changes
deploy/README.md
@@ -126,8 +126,22 @@ Following is the list of resource-groups and resources that should be created if

Wait for all pools to complete resizing before moving to the next steps.

Note: The Bicep template adds the Synapse workspace's Managed Identity to the Batch Account as `Contributor`. Alternatively, Custom Role Definitions can be used to assign the Synapse workspace's Managed Identity to the Batch Account with required Azure RBAC operations.

Note: The Bicep template adds the Synapse workspace's Managed Identity to the Batch Account with a Custom Role Access.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a line to state the reason why we prefer Custom Role Access will be helpful.

@karthick-rn
Copy link
Contributor

I haven't had the chance to test the PR, but overall the changes look good to me.

@sushilkm sushilkm marked this pull request as draft June 15, 2022 18:34
@senthilkungumaraj senthilkungumaraj added the on-hold Hold merge to main branch label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandarinamdar mandarinamdar mandarinamdar left review comments

@karthick-rn karthick-rn karthick-rn approved these changes

@senthilkungumaraj senthilkungumaraj Awaiting requested review from senthilkungumaraj

Assignees
No one assigned
Labels
draft enhancement New feature or request on-hold Hold merge to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use restrictive permissions for batch account rather than Contributor access
4 participants
@sushilkm @karthick-rn @mandarinamdar @senthilkungumaraj