Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-image: Remove virtualenv installed using pip #410

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

surajssd
Copy link
Member

@surajssd surajssd commented Apr 25, 2024

Remove triple installations of pip. Pip tool is installed once using tdnf and other two times using pip, so rely only on the one installed using tdnf.

Fixes: #403

Remove triple installations of pip. Pip tool is
installed once using tdnf and other two times
using pip, so rely only on the one installed using
tdnf.

Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
@surajssd surajssd force-pushed the remove-virtualenv-using-pip branch from 22d5954 to 14b7431 Compare April 26, 2024 21:44
@priyaananthasankar priyaananthasankar self-requested a review April 29, 2024 17:00
@darrentu
Copy link
Contributor

Would you mind elaborating how this has something to do with virtualenv?

@surajssd
Copy link
Member Author

Would you mind elaborating how this has something to do with virtualenv?

I think the commit and the issue needs updating. So now we only have two installations of virtualenv one using tdnf and one using pip. The virtualenv installed using pip is never used, only the tdnf based one is used, because the tdnf installed one is what shows up in the PATH first.

@surajssd surajssd merged commit c56f74c into Azure:master Apr 30, 2024
2 checks passed
@surajssd surajssd deleted the remove-virtualenv-using-pip branch April 30, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Image Update] Remove virtualenv installed using pip
2 participants