Merge pull request #624 from santhoshb-msft/sb-appconfigbugfix

update appconfig to save empty string instead of null #619
Azure · Dec 27, 2023 · b24c563 · b24c563
2 parents 3edef33 + 9a22bb4
commit b24c563
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/AdminSite/Controllers/ApplicationConfigController.cs b/src/AdminSite/Controllers/ApplicationConfigController.cs
@@ -119,6 +119,7 @@ public IActionResult ApplicationConfigDetails(int Id)
     [ValidateAntiForgeryToken]
     public IActionResult ApplicationConfigDetails(ApplicationConfiguration appConfig)
     {
+        appConfig.Value = appConfig.Value ?? string.Empty;
         this.appConfigService.SaveAppConfig(appConfig);
 
         this.ModelState.Clear();

diff --git a/src/AdminSite/Views/ApplicationConfig/ApplicationConfigDetails.cshtml b/src/AdminSite/Views/ApplicationConfig/ApplicationConfigDetails.cshtml
@@ -25,7 +25,7 @@
                         @Model.Name
                     </td>
                     <td>
-                        @if (@Model.Name.Equals("SMTPPassword") && @Model.Value.Length > 5)
+                        @if (@Model.Name.Equals("SMTPPassword") && @Model?.Value?.Length > 5)
                         {
                             @Html.EditorFor(model => model.Value, new { htmlAttributes = new { type ="password", @class = "form-control" } })
                         }

diff --git a/src/AdminSite/Views/ApplicationConfig/Index.cshtml b/src/AdminSite/Views/ApplicationConfig/Index.cshtml
@@ -31,7 +31,7 @@
                                         @item.Name
                                     </td>
                                     <td class="text-left">
-                                        @if (@item.Name.Equals("SMTPPassword") && @item.Value.Length > 5)
+                                        @if (@item.Name.Equals("SMTPPassword") && @item?.Value?.Length > 5)
                                         {
                                             @String.Format("{0}{1}", @item.Value.Substring(0,5), "****************");
                                         }