Skip to content

Commit

Permalink
Remove hardcoded file share name
Browse files Browse the repository at this point in the history
  • Loading branch information
SvenAelterman committed Nov 11, 2024
1 parent 5a386fd commit b9b4663
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
1 change: 1 addition & 0 deletions research-spoke/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,7 @@ module airlockModule './spoke-modules/airlock/main.bicep' = {

namingStructure: namingStructure
spokePrivateStorageAccountName: storageModule.outputs.storageAccountName
spokePrivateFileShareName: fileShareNames.shared
publicStorageAccountAllowedIPs: publicStorageAccountAllowedIPs

roles: rolesModule.outputs.roles
Expand Down
7 changes: 3 additions & 4 deletions research-spoke/spoke-modules/airlock/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ param namingConvention string
@minLength(3)
@maxLength(24)
param spokePrivateStorageAccountName string
param spokePrivateFileShareName string

@description('FUTURE: If true, the airlock will be configured to use the hub\'s airlock storage account for the egress review. If false, a new storage account will be created here.')
param useCentralizedReview bool
Expand Down Expand Up @@ -388,8 +389,7 @@ module ingestTriggerModule 'adfTrigger.bicep' = if (length(allowedIngestFileExte
sinkStorageAccountName: spokePrivateStorageAccountName
containerName: containerNames.ingest
additionalSinkFolderPath: 'incoming'
// TODO: Do not hardcode file share name 'shared'
sinkFileShareName: 'shared'
sinkFileShareName: spokePrivateFileShareName
// The URL of the project's Key Vault
// The project's KV stores the connection string to the project's file share
sinkConnStringKvBaseUrl: keyVault.properties.vaultUri
Expand All @@ -411,8 +411,7 @@ module extensionIngestTriggersModule 'adfTrigger.bicep' = [
sinkStorageAccountName: spokePrivateStorageAccountName
containerName: containerNames.ingest
additionalSinkFolderPath: 'incoming'
// TODO: Do not hardcode file share name 'shared'
sinkFileShareName: 'shared'
sinkFileShareName: spokePrivateFileShareName
// The URL of the project's Key Vault
// The project's KV stores the connection string to the project's file share
sinkConnStringKvBaseUrl: keyVault.properties.vaultUri
Expand Down

0 comments on commit b9b4663

Please sign in to comment.