Skip to content

Add support for only allowing specified file extensions to be ingested #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SvenAelterman
Copy link
Collaborator

No description provided.

@SvenAelterman SvenAelterman linked an issue Nov 11, 2024 that may be closed by this pull request
@SvenAelterman SvenAelterman added the spoke An issue related to the research spoke code label Nov 11, 2024
@SvenAelterman SvenAelterman marked this pull request as ready for review November 11, 2024 17:40
Copy link
Contributor

@vbalbarin vbalbarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the intention for the parameter allowedIngestFileExtensions is that if is an empty array, all files are ingested.

Does it make sense to make the default value be ['.*'] and handle that in the code?

@SvenAelterman
Copy link
Collaborator Author

I know the intention for the parameter allowedIngestFileExtensions is that if is an empty array, all files are ingested.

Does it make sense to make the default value be ['.*'] and handle that in the code?

@vbalbarin We could make that work, but it would be a lot harder in Bicep because we don't have much in the way of procedural statements.

Are you suggesting that because it would be easier to understand, vs. empty meaning all?

@SvenAelterman
Copy link
Collaborator Author

I know the intention for the parameter allowedIngestFileExtensions is that if is an empty array, all files are ingested.
Does it make sense to make the default value be ['.*'] and handle that in the code?

@vbalbarin We could make that work, but it would be a lot harder in Bicep because we don't have much in the way of procedural statements.

Are you suggesting that because it would be easier to understand, vs. empty meaning all?

@vbalbarin This is ready for your review again.

@vbalbarin vbalbarin merged commit dd4b9d4 into main Dec 17, 2024
1 of 2 checks passed
@vbalbarin vbalbarin deleted the 143-allow-specifying-file-types-for-ingest-using-airlock branch December 17, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spoke An issue related to the research spoke code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying file types for ingest using airlock
2 participants