Skip to content

fix(designers): Improving action name validation#8921

Open
Santiagosala2 wants to merge 1 commit intoAzure:mainfrom
Santiagosala2:fix/improve-action-name-validation
Open

fix(designers): Improving action name validation#8921
Santiagosala2 wants to merge 1 commit intoAzure:mainfrom
Santiagosala2:fix/improve-action-name-validation

Conversation

@Santiagosala2
Copy link

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

When you select an action or node to change its name in the details panel, you type a name and then realize that you added an extra space at the end. When you try to remove it (without hitting Enter), it says "The name already exists..." (even though there are no other actions with that name). Finally, your given name gets removed.

Root cause: The selected node's previous name is being included in the name uniqueness validation. The validation should only check against the names of other nodes.

This improves the user experience, as it's common to rename actions, mistype or add extra spaces, and want to correct them mid-edit — especially when copying names from elsewhere.

Impact of Change

  • Users: better user experience
  • Developers:
  • System:

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: Standalone designer

Contributors

@Santiagosala2

Screenshots/Videos

@github-actions
Copy link

🔒 AI Validation Pending

This PR is from an external contributor. AI validation will be performed after manual review by a maintainer.

Maintainers: Re-run this workflow after reviewing the changes if you want to enable AI validation.

@Santiagosala2
Copy link
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant