Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the RSA module explicitly #1629

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Use the RSA module explicitly #1629

merged 1 commit into from
Sep 11, 2019

Conversation

narrieta
Copy link
Member

@narrieta narrieta commented Sep 11, 2019

Reverting #1552

Reopened #1550


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@narrieta
Copy link
Member Author

#1552 added unit tests for this path

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@83f0f95). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1629   +/-   ##
==========================================
  Coverage           ?   66.51%           
==========================================
  Files              ?       78           
  Lines              ?    11182           
  Branches           ?     1570           
==========================================
  Hits               ?     7438           
  Misses             ?     3414           
  Partials           ?      330
Impacted Files Coverage Δ
azurelinuxagent/common/utils/cryptutil.py 50% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f0f95...94bdc8a. Read the comment docs.

@pgombar
Copy link
Contributor

pgombar commented Sep 11, 2019

LGTM

Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narrieta narrieta merged commit 1c453e8 into Azure:develop Sep 11, 2019
@narrieta narrieta deleted the openssl branch September 11, 2019 22:41
@johncrim
Copy link
Contributor

I object to this change - would be best to use pkey when available, and rsa only for older versions of openssl.

@narrieta
Copy link
Member Author

@johncrim - yes, we need to add code to collect some data to help us determine what is the best way to fallback to rsa when pkey is not available. We'll do that on the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants