Enable unit tests for Python 2.6 & 3.4 on Github Actions #3296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
requested review from
ZhidongPeng,
nagworld9 and
maddieford
as code owners
narrieta
commented
Jan 10, 2025
| @@ -385,19 +384,6 @@ def is_str_empty(s): | |||
| return is_str_none_or_whitespace(s) or is_str_none_or_whitespace(s.rstrip(' \t\r\n\0')) | |||
|
|
|||
|
|
|||
| def hash_strings(string_list): | |||
There was a problem hiding this comment.
hash_strings was being used only by the Monitor thread. It has a dependency on hashlib/OpenSSL. The Monitor thread does not really need a cryptographic hash, so I replaced it with Python's own hash function.
narrieta
commented
Jan 10, 2025
| @@ -411,8 +411,12 @@ def emulate_assertListEqual(self, seq1, seq2, msg=None, seq_type=None): | |||
| diffMsg = '\n' + '\n'.join( | |||
| difflib.ndiff(pprint.pformat(seq1).splitlines(), | |||
| pprint.pformat(seq2).splitlines())) | |||
| standardMsg = self._truncateMessage(standardMsg, diffMsg) | |||
| msg = self._formatMessage(msg, standardMsg) | |||
| # _truncateMessage and _formatMessage are not defined on Python 2.6; output the entire diff in that case | |||
There was a problem hiding this comment.
This issue has always been here. The only reason I noticed it is because a test that uses assertListEqual failed for an unrelated issue and this code raised an exception.
narrieta
commented
Jan 10, 2025
| useradd --shell /bin/bash --create-home -g waagent waagent | ||
| curl -sSf --retry 5 -o /tmp/python-${PYTHON_VERSION}.tar.bz2 https://dcrdata.blob.core.windows.net/python/python-${PYTHON_VERSION}.tar.bz2 | ||
| tar xjf /tmp/python-${PYTHON_VERSION}.tar.bz2 --directory / | ||
| chown -R waagent:waagent /home/waagent # The UID:GID in the tarball may not match those of the user, so we need to fix that. |
There was a problem hiding this comment.
Ubuntu 24 has a new user, ubuntu, with PID 1000 so now the PID in the tarball does not match waagent's (which now gets 1001)
added 2 commits
January 10, 2025 14:21
narrieta
changed the title
maddieford
previously approved these changes
Jan 13, 2025
tests/python_eol/README
Outdated
| setup done by ci_pr.yml is practically identical to the setup done by this Dockerfile, with minor | ||
| differences to account for the differences between Github Actions and Azure Pipelines. | ||
|
|
||
| NOTE: ci_pr.yml also depends on the patch_python_env.sh script. |
There was a problem hiding this comment.
nit:
Suggested change
| NOTE: ci_pr.yml also depends on the patch_python_env.sh script. | |
| NOTE: ci_pr.yml also depends on the patch_python_venv.sh script. |
maddieford
approved these changes
Jan 14, 2025
nagworld9
approved these changes
Jan 14, 2025
narrieta
added a commit
to narrieta/WALinuxAgent
that referenced
this pull request
Jan 14, 2025
* Use Ubuntu 24 for unit tests runs [Python 2.6 & 3.4] --------- Co-authored-by: narrieta@microsoft <narrieta> (cherry picked from commit 1f3ead2)
narrieta
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR also
* removes unnecessary dependency on hashlib
* updates the Azure Pipeline for unit tests to use Ubuntu 24
* patches the Python virtual environments used for unit tests to run on Ubuntu > 16