Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure Module 5 #135

Merged
merged 15 commits into from
Nov 9, 2023
Merged

Restructure Module 5 #135

merged 15 commits into from
Nov 9, 2023

Conversation

simonkurtz-MSFT
Copy link
Contributor

@simonkurtz-MSFT simonkurtz-MSFT commented Nov 9, 2023 •
edited
Loading

  • Restructures the module for easier flow of content
  • Externalizes all content to individual, reusable files and snippets
  • Consolidates dapr run snippets.
  • Removes SendGrid integration (to be moved to a different module)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-09 19:58 UTC

waelkdouh
waelkdouh approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@waelkdouh waelkdouh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonkurtz-MSFT simonkurtz-MSFT merged commit 121e9e5 into main Nov 9, 2023
3 checks passed
@simonkurtz-MSFT simonkurtz-MSFT deleted the feature/module-5-restructuring branch November 9, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waelkdouh waelkdouh waelkdouh approved these changes

@pankajagrawal16 pankajagrawal16 Awaiting requested review from pankajagrawal16

@tjoudeh tjoudeh Awaiting requested review from tjoudeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonkurtz-MSFT @waelkdouh