Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a metric to track the number of bytes we're sending to Kusto #598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jessejlt
Copy link
Member

No description provided.

@@ -93,6 +93,13 @@ var (
Help: "Counter of the number of logs uploaded to Kusto",
}, []string{"database", "table"})

IngestorUploadedBytes = promauto.NewGaugeVec(prometheus.GaugeOpts{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will quite do what we want. This gauge will get its value overwritten every time it uploads a segment to whatever size a given segment is, so we'll get a lot of different values for this gauge that don't really correspond to any consistent view of how much we're uploading.

I think if we want to keep track of the bytes being uploaded, this needs to be a Counter that we always append to. This way we're keeping track of the total as time goes on, and the multiple goroutines that write the metric won't step on each other and overwrite each other's value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants